Skip to content

Fix whitespace in query string parameters within pagination links #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Apr 9, 2024

Fix whitespace in query string parameters within pagination links. See conversation at dotnet/runtime#100792.

Fixes #1525.

QUALITY CHECKLIST

@bkoelman bkoelman force-pushed the fix-whitespace-in-pagination-links branch from 1ba8ff5 to 872c7d6 Compare April 9, 2024 00:42
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (dd4dc37) to head (872c7d6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1526   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         346      346           
  Lines       11063    11063           
  Branches     1814     1814           
=======================================
  Hits        10045    10045           
  Misses        669      669           
  Partials      349      349           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review April 9, 2024 01:34
@bkoelman bkoelman merged commit 750cb8a into master Apr 9, 2024
16 checks passed
@bkoelman bkoelman deleted the fix-whitespace-in-pagination-links branch April 9, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Differently encoded URLs in self and first links
1 participant