Skip to content

#218 Defaults data to be included in relationships rather than only w… #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2018

Conversation

crfloyd
Copy link
Contributor

@crfloyd crfloyd commented May 8, 2018

"data" element for relationships included on all responses regardless if an "include" for that relationship was sent in the request.

Closes #218

FEATURE

  • write tests that address the requirements outlined in the issue
  • fulfill the feature requirements
  • bump package version

…her than only when "include" for that relationship is set.
@jaredcnance
Copy link
Contributor

We'll need to add tests and I would like to pull this down and verify it locally before merging. Let me know if you want to write the tests. I don't mind since I'll be working with it anyways, but I don't want us spending duplicate effort.

@jaredcnance jaredcnance closed this May 8, 2018
@jaredcnance jaredcnance reopened this May 8, 2018
@crfloyd
Copy link
Contributor Author

crfloyd commented May 9, 2018

Sounds great. I will get some tests written and submitted today. Thanks!

@jaredcnance jaredcnance merged commit 8f811e0 into json-api-dotnet:master May 15, 2018
jaredcnance added a commit that referenced this pull request Aug 12, 2018
#218 Defaults data to be included in relationships rather than only w…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants