Skip to content

Feat/#39: Deeply Nested Inclusions #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Sep 4, 2018
Merged

Feat/#39: Deeply Nested Inclusions #378

merged 20 commits into from
Sep 4, 2018

Conversation

jaredcnance
Copy link
Contributor

@jaredcnance jaredcnance commented Aug 14, 2018

Closes #39

FEATURE

  • write tests that address the requirements outlined in the issue
  • fulfill the feature requirements
  • add unit tests for
    • Serialization
    • De-Serialization
  • add acceptance tests for
    • deeply nested inclusions spanning a HasMany relationship (?include=many.one)
    • deeply nested inclusions targeting a HasMany relationship (?include=one.many)

KNOWN ISSUES

  • sparse field-sets on included entities not supported yet
  • sort and filter on nested relationship attrs not yet supported

@jaredcnance jaredcnance changed the title Feat/#39: Deeply Nested Inclusions [WIP] Feat/#39: Deeply Nested Inclusions Aug 14, 2018
@jaredcnance
Copy link
Contributor Author

We still need to do some work on this, but I want to go ahead and get it out in v3.0.0-beta4 to drive community feedback.

@jaredcnance jaredcnance merged commit b073a0b into master Sep 4, 2018
@jaredcnance jaredcnance deleted the feat/#39 branch September 4, 2018 04:17
@jaredcnance jaredcnance changed the title [WIP] Feat/#39: Deeply Nested Inclusions Feat/#39: Deeply Nested Inclusions Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants