Skip to content

fix(#383): add operation processor overloads #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jaredcnance
Copy link
Contributor

@jaredcnance jaredcnance commented Sep 8, 2018

Closes #383


Currently failing because this creates ambiguous constructors 🙁

JsonApiDotNetCore.Internal.JsonApiException: Transaction failed on operation[0] (add) for an unexpected reason. ---> System.InvalidOperationException: Unable to activate type 'JsonApiDotNetCore.Services.Operations.Processors.CreateOpProcessor`2[JsonApiDotNetCoreExample.Models.Author,System.Int32]'. The following constructors are ambiguous:
Void .ctor(JsonApiDotNetCore.Services.ICreateService`2[JsonApiDotNetCoreExample.Models.Author,System.Int32], JsonApiDotNetCore.Serialization.IJsonApiDeSerializer, JsonApiDotNetCore.Builders.IDocumentBuilder, JsonApiDotNetCore.Internal.IContextGraph)
Void .ctor(JsonApiDotNetCore.Services.IResourceService`2[JsonApiDotNetCoreExample.Models.Author,System.Int32], JsonApiDotNetCore.Serialization.IJsonApiDeSerializer, JsonApiDotNetCore.Builders.IDocumentBuilder, JsonApiDotNetCore.Internal.IContextGraph)

I think this should be closed in favor of #399

If we register all forms automatically, there should be no need for these overloads...

@jaredcnance jaredcnance closed this Sep 8, 2018
@jaredcnance jaredcnance deleted the fix/#383 branch September 8, 2018 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

All IOpProcessors should accept every level of service layer interface
1 participant