Skip to content

fix(#394): register shorthand service types during discovery #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2018
Merged

fix(#394): register shorthand service types during discovery #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/JsonApiDotNetCore/Graph/ServiceDiscoveryFacade.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,25 @@ private string FormatResourceName(Type resourceType, IResourceNameFormatter reso
/// <param name="assembly">The assembly to search for resources in.</param>
public ServiceDiscoveryFacade AddAssemblyServices(Assembly assembly)
{
RegisterServiceImplementations(assembly, typeof(IResourceService<>));
RegisterServiceImplementations(assembly, typeof(IResourceService<,>));

RegisterServiceImplementations(assembly, typeof(ICreateService<>));
RegisterServiceImplementations(assembly, typeof(ICreateService<,>));

RegisterServiceImplementations(assembly, typeof(IGetAllService<>));
RegisterServiceImplementations(assembly, typeof(IGetAllService<,>));

RegisterServiceImplementations(assembly, typeof(IGetByIdService<>));
RegisterServiceImplementations(assembly, typeof(IGetByIdService<,>));

RegisterServiceImplementations(assembly, typeof(IGetRelationshipService<>));
RegisterServiceImplementations(assembly, typeof(IGetRelationshipService<,>));

RegisterServiceImplementations(assembly, typeof(IUpdateService<>));
RegisterServiceImplementations(assembly, typeof(IUpdateService<,>));

RegisterServiceImplementations(assembly, typeof(IDeleteService<>));
RegisterServiceImplementations(assembly, typeof(IDeleteService<,>));

return this;
Expand All @@ -122,8 +135,19 @@ public ServiceDiscoveryFacade AddAssemblyServices(Assembly assembly)
/// Add <see cref="IEntityRepository{T, TId}"/> implementations to container.
/// </summary>
/// <param name="assembly">The assembly to search for resources in.</param>
public ServiceDiscoveryFacade AddAssemblyRepositories(Assembly assembly)
=> RegisterServiceImplementations(assembly, typeof(IEntityRepository<,>));
public ServiceDiscoveryFacade AddAssemblyRepositories(Assembly assembly)
{
RegisterServiceImplementations(assembly, typeof(IEntityRepository<>));
RegisterServiceImplementations(assembly, typeof(IEntityRepository<,>));

RegisterServiceImplementations(assembly, typeof(IEntityWriteRepository<>));
RegisterServiceImplementations(assembly, typeof(IEntityWriteRepository<,>));

RegisterServiceImplementations(assembly, typeof(IEntityReadRepository<>));
RegisterServiceImplementations(assembly, typeof(IEntityReadRepository<,>));

return this;
}

private ServiceDiscoveryFacade RegisterServiceImplementations(Assembly assembly, Type interfaceType)
{
Expand Down