Skip to content

Feat/#293: Naming Conventions, Improvements to AutoDiscovery, and ResourceDefinition #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 3, 2018

Conversation

jaredcnance
Copy link
Contributor

@jaredcnance jaredcnance commented Sep 23, 2018

Closes #293
Closes #384
Closes #402

Note: this is the first step to creating a path that allows removal of [Attr] altogether, but we're not quite there yet. For now you will be able to change models from:

[Attr("compound-name")]
public string CompoundName { get; set; }

To:

[Attr]
public string CompoundName { get; set; }

OtherChanges

  • ContextGraphBuilder now allows resources to be added without specifying the resource name:
var builder = new ContextGraphBuilder();

// before
builder.AddResource<TestResource>("test-resources");

// after
builder.AddResource<TestResource>();
  • ResourceDefinition contains custom filters and default sort

FEATURE

  • write tests that address the requirements outlined in the issue
  • fulfill the feature requirements

TODO

  • Assess and identify any breaking changes
  • Tests on ResourceDefinition

@jaredcnance jaredcnance changed the title Feat/#293 [WIP] Feat/#293: Attribute Naming Conventions and Improvements to AutoDiscovery Sep 23, 2018
@jaredcnance jaredcnance changed the title [WIP] Feat/#293: Attribute Naming Conventions and Improvements to AutoDiscovery [WIP] Feat/#293: Naming Conventions and Improvements to AutoDiscovery Sep 23, 2018
@jaredcnance jaredcnance changed the title [WIP] Feat/#293: Naming Conventions and Improvements to AutoDiscovery Feat/#293: Naming Conventions and Improvements to AutoDiscovery Sep 24, 2018
@jaredcnance jaredcnance changed the title Feat/#293: Naming Conventions and Improvements to AutoDiscovery Feat/#293: Naming Conventions, Improvements to AutoDiscovery, and ResourceDefinition Sep 24, 2018
@jaredcnance jaredcnance merged commit 84f45a9 into master Oct 3, 2018
@jaredcnance jaredcnance mentioned this pull request Oct 3, 2018
@wisepotato
Copy link
Contributor

@jaredcnance maybe a good idea to add auto-discovery in the docs, or am i missing a page?

@jaredcnance
Copy link
Contributor Author

@wisepotato see this: https://json-api-dotnet.github.io/JsonApiDotNetCore/usage/resource-graph.html#auto-discovery

Let me know if something is missing or if the organization could be improved.

@jaredcnance jaredcnance deleted the feat/#293 branch February 21, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants