Skip to content

Nested sort #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Oct 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Examples/JsonApiDotNetCoreExample/Models/Person.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ public class Person : Identifiable, IHasMeta
[Attr("last-name")]
public string LastName { get; set; }

[Attr("age")]
public int Age { get; set; }

[HasMany("todo-items")]
public virtual List<TodoItem> TodoItems { get; set; }

Expand Down
28 changes: 14 additions & 14 deletions src/JsonApiDotNetCore/Data/DefaultEntityRepository.cs
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ public virtual IQueryable<TEntity> Get()
/// <inheritdoc />
public virtual IQueryable<TEntity> Filter(IQueryable<TEntity> entities, FilterQuery filterQuery)
{
if(_resourceDefinition != null)
if (_resourceDefinition != null)
{
var defaultQueryFilters = _resourceDefinition.GetQueryFilters();
if(defaultQueryFilters != null && defaultQueryFilters.TryGetValue(filterQuery.Attribute, out var defaultQueryFilter) == true)
if (defaultQueryFilters != null && defaultQueryFilters.TryGetValue(filterQuery.Attribute, out var defaultQueryFilter) == true)
{
return defaultQueryFilter(entities, filterQuery.Value);
}
Expand All @@ -106,17 +106,17 @@ public virtual IQueryable<TEntity> Filter(IQueryable<TEntity> entities, FilterQu
public virtual IQueryable<TEntity> Sort(IQueryable<TEntity> entities, List<SortQuery> sortQueries)
{
if (sortQueries != null && sortQueries.Count > 0)
return entities.Sort(sortQueries);
if(_resourceDefinition != null)
return entities.Sort(_jsonApiContext, sortQueries);

if (_resourceDefinition != null)
{
var defaultSortOrder = _resourceDefinition.DefaultSort();
if(defaultSortOrder != null && defaultSortOrder.Count > 0)
if (defaultSortOrder != null && defaultSortOrder.Count > 0)
{
foreach(var sortProp in defaultSortOrder)
{
foreach (var sortProp in defaultSortOrder)
{
// this is dumb...add an overload, don't allocate for no reason
entities.Sort(new SortQuery(sortProp.Item2, sortProp.Item1));
entities.Sort(_jsonApiContext, new SortQuery(sortProp.Item2, sortProp.Item1.PublicAttributeName));
}
}
}
Expand Down Expand Up @@ -189,10 +189,10 @@ private void AttachHasManyPointers(TEntity entity)
var relationships = _jsonApiContext.HasManyRelationshipPointers.Get();
foreach (var relationship in relationships)
{
if(relationship.Key is HasManyThroughAttribute hasManyThrough)
if (relationship.Key is HasManyThroughAttribute hasManyThrough)
AttachHasManyThrough(entity, hasManyThrough, relationship.Value);
else
AttachHasMany(relationship.Key as HasManyAttribute, relationship.Value);
AttachHasMany(relationship.Key as HasManyAttribute, relationship.Value);
}
}

Expand Down Expand Up @@ -289,15 +289,15 @@ public virtual async Task<bool> DeleteAsync(TId id)
/// <inheritdoc />
public virtual IQueryable<TEntity> Include(IQueryable<TEntity> entities, string relationshipName)
{
if(string.IsNullOrWhiteSpace(relationshipName)) throw new JsonApiException(400, "Include parameter must not be empty if provided");
if (string.IsNullOrWhiteSpace(relationshipName)) throw new JsonApiException(400, "Include parameter must not be empty if provided");

var relationshipChain = relationshipName.Split('.');

// variables mutated in recursive loop
// TODO: make recursive method
string internalRelationshipPath = null;
var entity = _jsonApiContext.RequestEntity;
for(var i = 0; i < relationshipChain.Length; i++)
for (var i = 0; i < relationshipChain.Length; i++)
{
var requestedRelationship = relationshipChain[i];
var relationship = entity.Relationships.FirstOrDefault(r => r.PublicRelationshipName == requestedRelationship);
Expand All @@ -315,7 +315,7 @@ public virtual IQueryable<TEntity> Include(IQueryable<TEntity> entities, string
internalRelationshipPath = (internalRelationshipPath == null)
? relationship.RelationshipPath
: $"{internalRelationshipPath}.{relationship.RelationshipPath}";

if(i < relationshipChain.Length)
entity = _jsonApiContext.ResourceGraph.GetContextEntity(relationship.Type);
}
Expand Down
Loading