fix(#425): fetching HasManyThrough returns no includes #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurei
changed the title
jaredcnance
reviewed
Oct 14, 2018
| @@ -0,0 +1,104 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
these need to be removed. doc artifacts are only supposed to be created when /p:DocFx=true and shouldn't be checked in. were these built automatically or were you building the docs intentionally?
| { | ||
| Type rightInstancesListType = typeof(List<>).MakeGenericType(hasManyThroughRelation.Type); | ||
| PropertyInfo rightPropertyOnLeft = _jsonApiContext.RequestEntity.EntityType.GetProperty(hasManyThroughRelation.InternalRelationshipName); | ||
| foreach (var leftInstance in included) |
There was a problem hiding this comment.
this is going to enumerate and materialize the query result set which is not something we should do yet. i'm thinking the work of mapping these values back should be moved to the serializer. looking closer it looks like the problem exists in the DocumentBuilder and the use of an older api that can't traverse the HasManyThrough relationship.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIX
Closes issue #425
Replaces pull request #426, which can be ignored and deleted.