Skip to content

Fixed HasManyThrough relationships returning empty data array without 'include' #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

XaserAcheron
Copy link
Contributor

Closes #453

BUG FIX

  • reproduce issue in tests
  • fix issue
  • bump package version

The basic gist here is that there was an iterator function that was returning an empty IEnumerable even if the property value for the relationship was null. All fixed now.

Let me know if I should bump the package version or anything. I'm not totally sure what the process is there.

Copy link
Contributor

@jaredcnance jaredcnance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jaredcnance jaredcnance merged commit bd162d0 into json-api-dotnet:master Dec 10, 2018
@XaserAcheron
Copy link
Contributor Author

Glad to help -- thanks for the merge & tag!

@XaserAcheron XaserAcheron deleted the fix-empty-hasmanythrough branch December 10, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

HasManyThrough relationships always return empty data:[] array on GET
2 participants