Skip to content

.NET Core 2.0 -> 2.1 #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2019
Merged

.NET Core 2.0 -> 2.1 #593

merged 1 commit into from
Oct 23, 2019

Conversation

wisepotato
Copy link
Contributor

First work in #559

  • upgrade .net core 2.0 to .net core 2.1 (ignore branch name)
  • Cleanup in tests (warnings have been ignored until now)
  • new startup format
  • catch some exceptions that are too broad (exception -> InvalidOperationException)

@wisepotato wisepotato requested a review from maurei October 23, 2019 12:08
@wisepotato wisepotato changed the title Update to 2.1 .NET Core 2.0 -> 2.1 Oct 23, 2019
maurei
maurei approved these changes Oct 23, 2019
View reviewed changes
.editorconfig

# CS0659: Type overrides Object.Equals(object o) but does not override Object.GetHashCode()
dotnet_diagnostic.CS0659.severity = silent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to suppress the error in RelationshipAttribute.cs, right? Are we sure it's fine to just ignore it rather than solving the issue? I don't know: I always ignored it until now, never looked into it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take it out, so it stays as a warning next release

@maurei maurei mentioned this pull request Oct 23, 2019
Merged
@wisepotato wisepotato merged commit b6fccd3 into dev-v4 Oct 23, 2019
@wisepotato wisepotato deleted the feat/upgrade-2.2 branch October 23, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurei maurei maurei approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wisepotato @maurei