Skip to content

Disabled resource hooks by default, as they are still experimental #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Disabled resource hooks by default, as they are still experimental #717

merged 1 commit into from
Apr 13, 2020

Conversation

bart-degreed
Copy link
Contributor

Discussed this with @maurei.

If time permits to finalize the work resource hooks, we may re-enable them for the stable release of V4. Biggest concern for now, it that it is an all-or-nothing experience. Once enabled, each GET request performs a full table fetch, which makes it unusable with large tables.

@bart-degreed bart-degreed requested a review from maurei April 8, 2020 13:18
@bart-degreed bart-degreed mentioned this pull request Apr 8, 2020
38 tasks
@bart-degreed bart-degreed merged commit 268cc7d into json-api-dotnet:master Apr 13, 2020
@bart-degreed bart-degreed deleted the resource-hooks-disabled branch April 13, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants