Code

Coding guidelines tweaks#965

Code

Merged

bart-degreed merged 32 commits intomasterjson-api-dotnet/JsonApiDotNetCore:masterfrom

coding-guidelines-tweaksjson-api-dotnet/JsonApiDotNetCore:coding-guidelines-tweaksCopy head branch name to clipboard

Mar 11, 2021

Commits

Commits on Mar 8, 2021

• Auto-formatted codebase using Resharper

  

  Bart Koelman

  committed
  4c6b02c

  Copy full SHA for 4c6b02c

• Replaced "var _" with discards

  

  Bart Koelman

  committed
  d909d9f

  Copy full SHA for d909d9f

• Test: fail the build with an inspectcode warning

  

  Bart Koelman

  committed
  0b998d0

  Copy full SHA for 0b998d0

• Test: fail the build with formatting violations

  

  Bart Koelman

  committed
  0afa692

  Copy full SHA for 0afa692

• Revert "Test: fail the build with formatting violations"

  Show description for aeead1f
  

  Bart Koelman

  committed
  aeead1f

  Copy full SHA for aeead1f

• Revert "Test: fail the build with an inspectcode warning"

  Show description for d369ab4
  

  Bart Koelman

  committed
  d369ab4

  Copy full SHA for d369ab4

• Empty commit

  

  Bart Koelman

  committed
  49a8334

  Copy full SHA for 49a8334

• Use extension method for null/empty checks and assertions

  

  Bart Koelman

  committed
  9b1ab18

  Copy full SHA for 9b1ab18

• Removed unused code

  

  Bart Koelman

  committed
  85c0205

  Copy full SHA for 85c0205

• Formatting: trim trailing whitespace

  

  Bart Koelman

  committed
  dc9dceb

  Copy full SHA for dc9dceb

• Boost various hints and suggestions to warning level during cibuild, to not bother devs too much while writing and debugging code.

  

  Bart Koelman

  committed
  362f637

  Copy full SHA for 362f637

• Fixed remaining warnings

  

  Bart Koelman

  committed
  8903c26

  Copy full SHA for 8903c26

• AV1250: Iterator method returns result of defered execution

  

  Bart Koelman

  committed
  599e103

  Copy full SHA for 599e103

• AV1706: Don't use single-letter variables

  

  Bart Koelman

  committed
  5068bd7

  Copy full SHA for 5068bd7

• AV1562: Do not use ref/out parameters

  

  Bart Koelman

  committed
  8d887e2

  Copy full SHA for 8d887e2

• Split up Act and Assert steps in tests

  

  Bart Koelman

  committed
  55534af

  Copy full SHA for 55534af

• AV1561: Do not return tuples with more than 2 parameters

  

  Bart Koelman

  committed
  a144bdd

  Copy full SHA for a144bdd

• Minor cleanup

  

  Bart Koelman

  committed
  1d73d87

  Copy full SHA for 1d73d87

• AV1008: Class should not be static

  

  Bart Koelman

  committed
  fe1f350

  Copy full SHA for fe1f350

• AV1010: Member hides inherited member

  

  Bart Koelman

  committed
  a303a33

  Copy full SHA for a303a33

• AV1115: Member contains the word 'and', which suggests doing multiple things

  

  Bart Koelman

  committed
  af9206d

  Copy full SHA for af9206d

• AV1210: Do not catch-all

  

  Bart Koelman

  committed
  d273ce1

  Copy full SHA for d273ce1

• AV1708: Do not use 'Helper' or 'Shared' in type names

  

  Bart Koelman

  committed
  3513dd1

  Copy full SHA for 3513dd1

• Added CSharpGuidelinesAnalyzer with settings

  

  Bart Koelman

  committed
  3a5d0ee

  Copy full SHA for 3a5d0ee

Commits on Mar 10, 2021

• AV1130: Use collection interface as return type

  

  Bart Koelman

  committed
  36b9961

  Copy full SHA for 36b9961

• Simplified test code for hooks

  

  Bart Koelman

  committed
  a8e6356

  Copy full SHA for a8e6356

• Automated code cleanup

  

  Bart Koelman

  committed
  06210db

  Copy full SHA for 06210db

• Refactored TypeHelper

  

  Bart Koelman

  committed
  be1cb11

  Copy full SHA for be1cb11

• Set AV1555 to Warning level

  

  Bart Koelman

  committed
  dc93930

  Copy full SHA for dc93930

Commits on Mar 11, 2021

• Renamed ITraversalHelper to INodeNavigator

  

  Bart Koelman

  committed
  d01c1f2

  Copy full SHA for d01c1f2

• Renamed IHookExecutorHelper to IHookContainerProvider

  

  Bart Koelman

  committed
  e644a0f

  Copy full SHA for e644a0f

• Fixed cibuild

  

  Bart Koelman

  committed
  88bd432

  Copy full SHA for 88bd432