Skip to content

Extend if/then/else tests on unevaluated properties #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2021
Merged

Extend if/then/else tests on unevaluated properties #500

merged 1 commit into from
Jul 19, 2021

Conversation

nezhar
Copy link
Contributor

@nezhar nezhar commented Jul 14, 2021

Adds some additional test cases for unevaluated properties combined with if/then/else.

@nezhar nezhar mentioned this pull request Jul 14, 2021
Merged
jdesrosiers
jdesrosiers requested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you add this to draft-future as well?

@nezhar
Copy link
Contributor Author

nezhar commented Jul 16, 2021

Looks good to me. Can you add this to draft-future as well?

Sure, I added the change 🙂

@nezhar nezhar requested a review from jdesrosiers July 16, 2021 13:31
Julian
Julian reviewed Jul 19, 2021
View reviewed changes
Copy link
Member

@Julian Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Julian Julian merged commit fd0aa9f into json-schema-org:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian Julian Julian left review comments

@jdesrosiers jdesrosiers Awaiting requested review from jdesrosiers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nezhar @Julian @jdesrosiers