-
-
Notifications
You must be signed in to change notification settings - Fork 213
Add glossary entries for keyword and meta-schema. #469
Conversation
✅ Deploy Preview for condescending-hopper-c3ed30 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
learn/glossary.md
Outdated
A [schema](#schema) which is itself intended to describe other *schemas*. | ||
|
||
JSON Schema defines a language for describing any [instance](#instance) using a schema written in JSON. | ||
Since schemas are themselves JSON values, they may be opaquely treated as *instances*, and therefore described by other schemas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it's not entirely opaque, §9.3.3 notes that in some circumstances an alternate way of handling schema-instances SHOULD be implemented. I'm not quite sure how that should be dealt with as we don't want a huge tangent on an obscure case, but it should be acknowledged that meta-schema validation can be more complex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you happy with deleting the word opaquely
and just saying may also be treated as instances
? That matches the language from §4.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Julian yeah that would work, thanks! Better than too much detail on the basic concept. I'll bonk the approve button again when I see that change, but feel free to consider it pre-approved - everything else is great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, done. Thanks.
Also loosens the language around schema<->instance interaction from #462 (comment).