Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Add a glossary entry for JSON. #521

Merged
merged 2 commits into from
May 11, 2023
Merged

Add a glossary entry for JSON. #521

merged 2 commits into from
May 11, 2023

Conversation

Julian
Copy link
Member

@Julian Julian commented May 2, 2023

Refs: json-schema-org/community#199

@netlify
Copy link

netlify bot commented May 2, 2023

Deploy Preview for condescending-hopper-c3ed30 ready!

Name Link
🔨 Latest commit c0b1495
🔍 Latest deploy log https://app.netlify.com/sites/condescending-hopper-c3ed30/deploys/6453c208fb449c0008ee2c9b
😎 Deploy Preview https://deploy-preview-521--condescending-hopper-c3ed30.netlify.app/learn/glossary
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment on lines 44 to 45
JSON Schema, distinctly, is built *on top* of JSON, in that JSON [schemas](#schema) are themselves JSON objects which describe other JSON objects.
The two are, however, entirely different pieces of the conceptual puzzle, with JSON being a concrete format for *representing* data and JSON Schema being a way to *schematize* data which is written in the JSON format.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something we want to convey in a glossary entry for JSON is that JSON Schema doesn't require that your schemas or instances are JSON, just that they are compatible with JSON. I think the current wording implies a tighter connection to JSON than is currently accurate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's mentioned in the entry for schemas below on the page -- think we should repeat it here as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to give a full explanation like below, but I think adding some qualifiers would help. I think people don't generally read a glossary top to bottom, they jump around to the terms they don't know. So, we can't assume they read other parts.

Example: "which is written in the JSON format" => "which is written in a JSON-compatible format".

Co-authored-by: Jason Desrosiers <[email protected]>
@Julian
Copy link
Member Author

Julian commented May 4, 2023

Thanks, applied both suggestions I think!

@Julian Julian merged commit 734c86e into main May 11, 2023
@Julian Julian deleted the glossary-json branch May 11, 2023 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants