Remove bookending requirement for dynamicRef #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jdesrosiers
force-pushed
the
dynamicref-no-bookend
branch
from
7960f6f to
f7df239
Compare
|
Force pushed to fix conflicts caused by merging IRI changes. |
erosb
reviewed
Nov 13, 2021
6 tasks
Relequestual
approved these changes
Nov 19, 2021
1 task
jdesrosiers
added a commit
to jdesrosiers/json-schema-spec
that referenced
this pull request
Jun 30, 2022
* Remove bookending requirement for dynamicRef * Add $dynamicRef changes to change log
jdesrosiers
added a commit
to jdesrosiers/json-schema-spec
that referenced
this pull request
Jun 30, 2022
* Remove bookending requirement for dynamicRef * Add $dynamicRef changes to change log
jdesrosiers
added a commit
that referenced
this pull request
Jul 8, 2022
* Remove bookending requirement for dynamicRef * Add $dynamicRef changes to change log
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1064
Discussion about changes to
$dynamicRefbehavior are still on going, but I want to capture the part that we did get consensus on, which is to remove the bookending requirement.