Update regex concerns for subschema application #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@awwright @Relequestual @dlax @philsturgeon @gregsdennis anyone... this is just a cut-paste moving the section from Validation to Core, leaving a reference to Core in the original location in the validation spec. It's trivial. Would someone please take a look and review? It's been 2.5 weeks. |
dlax
approved these changes
Jun 12, 2018
|
@handrews this PR has conflicts. |
Move the main text into core, and just reference it from validation.
gregsdennis
approved these changes
Jun 12, 2018
|
Ugh, this is exactly why I hate it when trivial PRs get left hanging out for a long time. I forget the relevant changes- in this case the JSON RFC update. Thanks, @gregsdennis! |
awwright
reviewed
Jun 13, 2018
| <xref target="integers" format="counter"></xref> above. | ||
| <xref target="language" format="counter"></xref>, | ||
| <xref target="integers" format="counter"></xref>, and | ||
| <xref target="regex" format="counter"></xref>above. |
There was a problem hiding this comment.
does this need a space before "above" ?
There was a problem hiding this comment.
Ugh, yes. Fixed in PR #603 if you'd be so kind as to review :-) Thanks for catching it.
awwright
reviewed
Jun 13, 2018
| <xref target="integers" format="counter"></xref> above. | ||
| <xref target="language" format="counter"></xref>, | ||
| <xref target="integers" format="counter"></xref>, and | ||
| <xref target="regex" format="counter"></xref>above. |
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the main text into core, and just reference it from validation.
This somehow got left off the PR back when the applicators moved to core, and I only just now noticed. Core now includes keywords that use regexes.