Update xml2rfc required version #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work now: https://travis-ci.org/json-schema-org/json-schema-spec/builds/499101137 |
handrews
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
The linter warnings are from the examples for output. I only found them recently, and got them down to fewer complaints by using shorter property names, but some of those $refs are pretty intractable. Might need to rework those examples a bit more.
Anyway, it's unrelated to the xml2rfc version problem- thanks for figuring this out and fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this works