output schema fixes #940
output schema fixes #940
Conversation
it is possible to have both $ref and $recursiveRef in the traversed schema path
|
@karenetheridge Could you link to the portions of the spec that this file references, please? Just to make sure that this change is valid. |
|
re absoluteKeywordLocation: https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.section.10.3.2 re patterns: https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.section.6.4 |
|
@karenetheridge
Oh... this is the schema that describes the output format... nvm. |
| @@ -46,18 +46,18 @@ | |||
| }, | |||
| { | |||
| "if": { | |||
| "oneOf": [ | |||
| "anyOf": [ | |||
There was a problem hiding this comment.
Why this change? Are you expecting $ref and $recursiveRef to both appear in the keyword location?
... I suppose they could....
okay.
There was a problem hiding this comment.
sure, if there is a $recursiveRef in the subschema at the other end of a $ref, it could certainly happen.
I have a test case with .../$ref/$ref/$ref/$ref/.. :) -- https://github.com/karenetheridge/JSON-Schema-Draft201909/blob/master/t/errors.t#L788
These are all required for validation against the metaschemas to succeed.
json-schema-org/json-schema-spec#923 (fixes to output/schema.json)
json-schema-org/json-schema-spec#940 (not yet merged; another fix to output/schema.json)
These are all required for validation against the metaschemas to succeed.
json-schema-org/json-schema-spec#923 (fixes to output/schema.json)
json-schema-org/json-schema-spec#940 (not yet merged; another fix to output/schema.json)
These are all required for validation against the metaschemas to succeed.
json-schema-org/json-schema-spec#923 (fixes to output/schema.json)
json-schema-org/json-schema-spec#940 (not yet merged; another fix to output/schema.json)
|
@gregsdennis If you'll approve, let's merge this? |
Fixed some errors in output/schema.json