Skip to content

Add Resolves/Closes Keywords and updated PR Template #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2024
Merged

Add Resolves/Closes Keywords and updated PR Template #357

merged 2 commits into from
Mar 2, 2024

Conversation

aialok
Copy link
Member

@aialok aialok commented Feb 25, 2024 •
edited by benjagm
Loading

What kind of change does this PR introduce?

  • Added PR dependencies in workflow, Improve PR-Template.

**Issue Number: #343
Resolves: #343

Snapshots:

  • NA

If relevant, did you update the documentation?

  • NA

Summary

  • Added :
-  Closes #___ <!-- Replace ___ with the issue number this PR resolves -->
-  Related to #___ <!-- Use when the PR doesn't completely resolve an issue -->
-  Others? <!-- Add any additional notes or references here -->
  • Updated PR-Template for better review.
  • Added PR Dependencies

Does this PR introduce a breaking change?

  • No

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

Yes/No
[JUSTIFICATION]

gregsdennis
gregsdennis requested changes Feb 25, 2024
View reviewed changes
@aialok
Copy link
Member Author

aialok commented Feb 25, 2024

Making the desire changes.
Thank you @gregsdennis for your review : )

@aialok aialok requested a review from gregsdennis February 25, 2024 17:45
@gregsdennis gregsdennis requested a review from a team February 25, 2024 21:29
@aialok aialok requested a review from benjagm February 27, 2024 20:31
benjagm
benjagm approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benjagm benjagm added the Status: Completed Nothing further to be done with this issue. label Feb 29, 2024
@benjagm benjagm merged commit 4cbd61e into json-schema-org:main Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsdennis gregsdennis gregsdennis approved these changes

@benjagm benjagm benjagm approved these changes

Assignees
No one assigned
Labels
Status: Completed Nothing further to be done with this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Resolves/Closes Keywords to PR Template
3 participants
@aialok @gregsdennis @benjagm