Skip to content

added dates to specification link #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

praveen-rikhari
Copy link
Contributor

@praveen-rikhari praveen-rikhari commented Feb 28, 2024

GitHub Issue: #123
Resolves #123

Summary:

  • added published/release dates for each versions (e.g. draft 6, draft 7)

Files Changes

  • pages/specification-links.md

Before
Can see on website here

After
screen-recording.webm

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

Yes/No
No

@praveen-rikhari
Copy link
Contributor Author

@benjagm Please review

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found something in Draft 4.

Great work @praveen-rikhari !!

@@ -399,24 +404,28 @@ _These were updated without changing functionality or meta-schemas due to a few
- JSON Reference: [draft-pbryan-zyp-json-ref-03](https://tools.ietf.org/html/draft-pbryan-zyp-json-ref-03) ([changes](https://tools.ietf.org/html/draft-pbryan-zyp-json-ref-03#appendix-A))
* [JSON Schema meta-schema](../../draft-04/schema)
* [JSON Hyper-Schema meta-schema](../../draft-04/hyper-schema)
- Published: 2013
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Published: 2013
- Published: 31-January-2013

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjagm Thanks for reviewing
okk I'll fix this

Co-authored-by: Benjamin Granados <[email protected]>
@praveen-rikhari
Copy link
Contributor Author

@benjagm I deleted that #388 and merged the requested changes on to this PR (#386)
Now you can leave it for review

@benjagm benjagm added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed. label Feb 29, 2024
@benjagm benjagm merged commit 6c48bbe into json-schema-org:main Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed The issue has a PR attached to it which needs to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs request: adding dates to Specification Links
2 participants