Skip to content

Added Case Studies page in Overview Section #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 20, 2024
Merged

Added Case Studies page in Overview Section #473

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
22660a2
updated UI of blog-page
Mar 3, 2024
d6bf52c
Added Case Studies Page
Mar 6, 2024
94c309c
fixed linting errors
Mar 6, 2024
944c175
Added casestudies
TamannaVerma99 Mar 12, 2024
61b9c16
changing index.page.tsx
TamannaVerma99 Mar 12, 2024
aa9acca
Delete components/CustomComponent.tsx
TamannaVerma99 Mar 12, 2024
2870661
Delete pages/overview/casestudies.md
TamannaVerma99 Mar 12, 2024
0547435
removed unnecessary changes
TamannaVerma99 Mar 12, 2024
ab7bf30
removed unnecessary files
TamannaVerma99 Mar 12, 2024
f08b64c
fixed bug
TamannaVerma99 Mar 12, 2024
d8699b3
removed changes
TamannaVerma99 Mar 12, 2024
66b5ef3
removed unnecessary files
TamannaVerma99 Mar 12, 2024
e7378cd
Pushing last changes.
benjagm Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions .github/workflows/greet_on_first_merge.yml
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions components/CarbonsAds.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,6 @@ CarbonAds.stylesheet = {
margin-top: 4px;
color: rgb(100 116 139);
}

@media (max-width: 1023px) {
#carbonads-container {
display: none;
}
}
`,
};

Expand Down
2 changes: 1 addition & 1 deletion components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,4 +578,4 @@ export const DocsNav = () => {
};

export const getLayout = (page: React.ReactNode) =>
getSiteLayout(<SidebarLayout>{page}</SidebarLayout>);
getSiteLayout(<SidebarLayout>{page}</SidebarLayout>);
1 change: 1 addition & 0 deletions components/StyledMarkdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,7 @@ const StyledMarkdownBlock = ({ markdown }: { markdown: string }) => {
);
},
},

TableOfContent: {
component: ({ depth }) => {
// eslint-disable-next-line react-hooks/rules-of-hooks
Expand Down
59 changes: 59 additions & 0 deletions data/casestudies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please build a real data set with our case studies? This is the list:
https://json-schema.org/blog?type=Case%20Study

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @benjagm
where do we want to direct the link we are adding in each casestudy card? According to card's implementation the link I am adding is shown as read more.
e.g if I have added homepage url in link prop of card it is showing read more and on clicking read more i am directed to home page.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do we want to direct the link we are adding in each casestudy card?

The url will be the case study blog post.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Got it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @benjagm I have some doubts regarding data set
What are we going to add at the place of logo and are we going to add complete title of blog post if yes then it will be too large because in the implementation of card title it is made by using h3 so how should I proceed with it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find the company logos and add them to the folder: https://github.com/json-schema-org/website/tree/main/public/img/logos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay! and what about the size of card title do I need to change the card component?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing the size of the card? Try to use this one and if you need to make some adjustments do it but just for the card features that you need. Remember that the card is now going to be used in 3 different pages.

For example you can change the logo size or fix a bug but not the whole card component without reason. Right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion @benjagm
I am not asking to change the card size but the bug is related to title if I directly put title in this component it will look like this

cr

It is because title is written with h3 size in card component.
I will definitely not change the card component directly but if there is no other way I will just make a copy of this component and make changes to that one .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case feel free to modify it

{
"logo": "/img/logos/logo-blue.svg",
"summary": "Here we are going to give summary about the casestudy.",
"links":
{
"lang": "URL1",
"url": "/"
}

},
{
"logo": "/img/logos/logo-blue.svg",
"summary": "Here we are going to give summary about the casestudy.",
"links":
{
"lang": "URL1",
"url": "/"
}

},{
"logo": "/img/logos/logo-blue.svg",
"summary": "Here we are going to give summary about the casestudy.",
"links":
{
"lang": "URL1",
"url": "/"
}

},{
"logo": "/img/logos/logo-blue.svg",
"summary": "Here we are going to give summary about the casestudy.",
"links":
{
"lang": "URL1",
"url": "/"
}

},{
"logo": "/img/logos/logo-blue.svg",
"summary": "Here we are going to give summary about the casestudy.",
"links":
{
"lang": "URL1",
"url": "/"
}

},{
"logo": "/img/logos/logo-blue.svg",
"summary": "Here we are going to give summary about the casestudy.",
"links":
{
"lang": "URL1",
"url": "/"
}

}
]

2 changes: 1 addition & 1 deletion pages/blog/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,4 +326,4 @@ export default function StaticMarkdownPage({
);
}

StaticMarkdownPage.getLayout = getLayout;
StaticMarkdownPage.getLayout = getLayout;
Loading