Skip to content

Copyright Added in the Footer Section. #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Copyright Added in the Footer Section. #607

wants to merge 4 commits into from

Conversation

its-VinayKumar
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:
#573. Bug Resolved

Screenshots/videos:

If relevant, did you update the documentation?

Summary
Copyright implement in the Footer Section.

Screenshot (209)

@its-VinayKumar its-VinayKumar requested a review from a team as a code owner March 26, 2024 10:11
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It work great in desktop but not in mobile

Screenshot 2024-03-26 at 14 20 46

@@ -182,10 +182,10 @@
resolved "https://registry.yarnpkg.com/@eslint-community/regexpp/-/regexpp-4.10.0.tgz#548f6de556857c8bb73bbee70c35dc82a2e74d63"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not modify this file.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It work great in desktop but not in mobile

Screenshot 2024-03-26 at 14 20 46

@@ -56,7 +56,7 @@
"@typescript-eslint/eslint-plugin": "^6.10.0",
"@typescript-eslint/parser": "^6.10.0",
"autoprefixer": "^10.4.16",
"eslint": "8.53.0",
"eslint": "^8.57.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not modify this file.

@its-VinayKumar
Copy link
Contributor Author

@benjagm Ok, But the changes in package.json and yarn.lock are automatically done.

Updated the Copyright  of the site in the mobile view.
@its-VinayKumar
Copy link
Contributor Author

Screenshot (214)
@benjagm Changes Updated. Please merge the file. :)

@DhairyaMajmudar
Copy link
Member

@benjagm Ok, But the changes in package.json and yarn.lock are automatically done.

Yeah, its because you are using npm instead of yarn. Discussion here will help you #498

@its-VinayKumar its-VinayKumar closed this by deleting the head repository Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants