Fixes #669: use the language-tags package to check the lang rule
#670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `language-tags` package provides language tag validation functionality based on the latest IANA language subtag registry. This PR makes use of this package instead of manually parsing tags like before. File `src/util/attributes/ISO.json` is removed then. Signed-off-by: imtsuki <[email protected]>
2 similar comments
ljharb
approved these changes
Mar 13, 2020
|
As there's no response for a while, I'll close this PR. |
|
Let’s please leave it open; there’s no expiration date on PRs and I’d still like to get it in :-) |
@imtsuki apologies for the delay in response. This is a great change; thank you for proposing it! |
jessebeach
approved these changes
Jun 12, 2020
ljharb
reviewed
Jun 12, 2020
Co-authored-by: Jordan Harband <[email protected]>
jessebeach
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
language-tagspackage provides language tag validation functionality based on the latest IANA language subtag registry.Instead of manually parsing tags like before, this PR makes use of this package and makes the
langrule more exhaustive and more robust. Filesrc/util/attributes/ISO.jsonis removed then.Signed-off-by: imtsuki [email protected]