Skip to content

Commit 11bf35a

Browse files
committed
Allow empty annotation values
Fixes: openshift#11175 Annotations with empty values can be used, for example, in oadm diagnostics logging. This patch removes the client-side check for empty values in an annotation key-value pair. **Before** ``` $ oc annotate pod zookeeper-1 openshift.io/node-selector="" --overwrite error: invalid annotation format: openshift.io/node-selector= ``` **After** ``` $ oc annotate pod zookeeper-1 openshift.io/node-selector="" --overwrite pod "zookeper-1" annotated ``` ``` $ oc get po/zookeeper-1 --template='{{.metadata.annotations}}' map[... openshift.io/node-selector: openshift.io/scc:anyuid test-label:test] ```
1 parent 6fe1c03 commit 11bf35a

File tree

1 file changed

+1
-1
lines changed
  • vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util

1 file changed

+1
-1
lines changed

vendor/k8s.io/kubernetes/pkg/kubectl/cmd/util/helpers.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)