Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oc annotate does not allow setting an annotation to empty #11175

Closed
jcantrill opened this issue Sep 30, 2016 · 4 comments
Closed

oc annotate does not allow setting an annotation to empty #11175

jcantrill opened this issue Sep 30, 2016 · 4 comments
Assignees
@juanvallejo
Labels
component/cli component/internal-tools kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@jcantrill
Copy link
Contributor

oc annotate does not allow setting an annotation to empty. Trying to advise users to set a project node selector to empty for use in oadm diagnostics logging.

Version

oc v1.3.0-alpha.3
kubernetes v1.3.0+507d3a7
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server https://172.28.128.4:8443
openshift v1.3.0-alpha.3
kubernetes v1.3.0+507d3a7

Steps To Reproduce
  1. Create a project with an annotation
  2. Try to update the annotation to empty
Current Result

$ oc annotate namespace logging openshift.io/node-selector="" --overwrite
error: invalid annotation format: openshift.io/node-selector=

Expected Result

Yeah for you

Additional Information
$ oc annotate namespace logging openshift.io/node-selector="" --overwrite --loglevel=8
I0930 18:31:43.327516    6431 loader.go:330] Config loaded from file /var/lib/openshift/openshift.local.config/master/admin.kubeconfig
F0930 18:31:43.327814    6431 helpers.go:108] error: invalid annotation format: openshift.io/node-selector=
@jcantrill jcantrill added kind/bug Categorizes issue or PR as related to a bug. component/cli priority/P2 area/tools labels Sep 30, 2016
@0xmichalis
Copy link
Contributor

cc: @openshift/cli-review probably needs an upstream issue

@juanvallejo juanvallejo self-assigned this Oct 4, 2016
juanvallejo added a commit to juanvallejo/origin that referenced this issue Oct 4, 2016
@juanvallejo
Allow empty annotation values
11bf35a 
Fixes:
openshift#11175

Annotations with empty values can be used, for example, in oadm
diagnostics logging. This patch removes the client-side check for empty
values in an annotation key-value pair.

**Before**
```
$ oc annotate pod zookeeper-1 openshift.io/node-selector="" --overwrite
error: invalid annotation format: openshift.io/node-selector=
```

**After**
```
$ oc annotate pod zookeeper-1 openshift.io/node-selector="" --overwrite
pod "zookeper-1" annotated
```

```
$ oc get po/zookeeper-1 --template='{{.metadata.annotations}}'
map[... openshift.io/node-selector: openshift.io/scc:anyuid test-label:test]
```
This was referenced Oct 4, 2016
Merged
Merged
juanvallejo added a commit to juanvallejo/origin that referenced this issue Oct 4, 2016
@juanvallejo
UPSTREAM: 34020: Allow empty annotation values
9a90e85 
Fixes:
openshift#11175

Annotations with empty values can be used, for example, in oadm
diagnostics logging. This patch removes the client-side check for empty
values in an annotation key-value pair.

**Before**
```
$ oc annotate pod zookeeper-1 openshift.io/node-selector="" --overwrite
error: invalid annotation format: openshift.io/node-selector=
```

**After**
```
$ oc annotate pod zookeeper-1 openshift.io/node-selector="" --overwrite
pod "zookeper-1" annotated
```

```
$ oc get po/zookeeper-1 --template='{{.metadata.annotations}}'
map[... openshift.io/node-selector: openshift.io/scc:anyuid test-label:test]
```
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Oct 5, 2016
Merge pull request #34020 from juanvallejo/jvallejo/allow-empty-annot…
d4088fc 
…ation-values

Automatic merge from submit-queue

Allow empty annotation values

Related downstream issue: openshift/origin#11175

**Release note**:
```release-note
release-note-none
```

Annotations with empty values can be used, for example, in diagnostics
logging. This patch removes the client-side check for empty values in
an annotation key-value pair.

**Before**
```
$ kubectl annotate pod zookeeper-1 node-selector="" --overwrite
error: invalid annotation format: node-selector=
```

**After**
```
$ kubectl annotate pod zookeeper-1 node-selector="" --overwrite
pod "zookeper-1" annotated
```

```
$ kubectl get po/zookeeper-1 --template='{{.metadata.annotations}}'
map[... node-selector: test-label:test]
```

@fabianofranz @liggitt
@juanvallejo
Copy link
Contributor

both origin and upstream PRs have been merged, closing this issue, please re-open if necessary

@smarterclayton
Copy link
Contributor

Did this make it to 3.7.1?

@juanvallejo
Copy link
Contributor

@smarterclayton yes: https://github.com/openshift/origin/commits/v3.7.1?before=ee2e38215f562d6dad9b30da8dcec2fbf5a6cf60+35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juanvallejo juanvallejo

Labels
component/cli component/internal-tools kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@danmcp @smarterclayton @0xmichalis @juanvallejo @jcantrill