Cannot annotate Collections with @Datapoints, only arrays

[MatrixFrog]

Currently, the @DataPoints annotation can only be applied to arrays, not Lists or other Collections, as described in http://stackoverflow.com/questions/2967912/junit-theories-why-cant-i-use-lists-instead-of-arrays-as-datapoints

It would be nice if you could use Lists as well, as they are often easier to work with.

[MatrixFrog]

I've come up with a solution to this, which is still pretty rough. Rather than looking at the type of a Collection, to make sure that's a Collection where T is the datatype expected by the Theory, it just cycles through EVERY Collection that is annotated with @DataPoints and selects only the elements of type T. If you have a large collection of Strings, as well as a large collection of Integers, for example, this could potentially result in serious performance issues. But it does seem to work (I also included a small unit test). Please offer suggestions of how to improve it!

http://github.com/MatrixFrog/junit

[MatrixFrog]

When I worked on this before, I didn't understand git very well, and it was also well before "Pull Requests 2.0" so I've redone it and cleaned up a little bit:

https://github.com/KentBeck/junit/pull/175

[dsaff]

@pimterry, were you doing some work on this, or is my memory completely broken?

[pimterry]

Yes, I was. Sorry I've got a bit delayed recently in tidying up the previous bits I started, but I'll try and get them and then this in within the next week or two :-)

[dsaff]

No problem, just doing some people-to-issue bookkeeping. Thanks!

[Stephan202]

It is my understanding that this issue has been resolved by #658; it should be closed.

[kcooney]

Good point. Thanks, @Stephan202 !