Skip to content

Change to Markdown extension for ease of viewing #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2012

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp mentioned this pull request Oct 15, 2012
@dsaff
Copy link
Member

dsaff commented Oct 18, 2012

We'll need to update https://github.com/KentBeck/junit/blob/master/build.xml#L136 as well, right?

@marcphilipp
Copy link
Member Author

Good catch! I wasn't aware of this Ant target. Now that I know, I
think we should rename all release note text files and change the Ant
target.

We might break some URLs pointing to old release note files, though.

@dsaff What do you think?

@dsaff
Copy link
Member

dsaff commented Oct 18, 2012

Well, we could copy all the old ones, and just use md going forward, for the best of both worlds, right?

@marcphilipp
Copy link
Member Author

Alternative: Copy txt files to md ones and replace content of txt files with "Please see $FILENAME.md". This way, we wouldn't have the duplication and wouldn't break any links. Thoughts?

@dsaff
Copy link
Member

dsaff commented Oct 19, 2012

Works for me. Thanks!

Because we do not want to break any URLs pointing to the .txt files,
we keep them around but they contain nothing more but a short hint
to look at the .md ones.
@marcphilipp
Copy link
Member Author

Ok, pushed the changes as discussed above. Should be ready to be merged from my point of view.

dsaff pushed a commit that referenced this pull request Oct 22, 2012
Change to Markdown extension for ease of viewing
@dsaff dsaff merged commit 2f879b9 into junit-team:master Oct 22, 2012
@dsaff
Copy link
Member

dsaff commented Oct 22, 2012

Thanks!

@marcphilipp marcphilipp deleted the release-notes-file-extension branch January 3, 2013 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants