Add error message to TemporaryFolder.newFolder("String/String") #959
Conversation
| @@ -1,18 +1,15 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <projectDescription> | |||
| <name>junit</name> | |||
There was a problem hiding this comment.
Please revert the changes to this file:
git checkout master .project
Ditto for the other non-java files
|
Ops, Sure thing... Thanks for the review ! |
| */ | ||
| private void validateIOSeparator(String folderName) throws IOException { | ||
| if (folderName.contains(File.separator)) { | ||
| throw new IOException(String.format("%s%s%s%n%s", |
There was a problem hiding this comment.
It's not very readable to use %s to format constant strings. I was suggesting that you could use String.format so you could use File.separator in the message without concatenating strings.
|
Thanks for the changes! A few more minor changes. After committing them, could you squash your commits? See https://github.com/junit-team/junit/wiki/Pull-Requests for instructions |
| thrown.expect(IOException.class); | ||
| thrown.expectMessage(String.format("%s%s%s%n%s", | ||
| "It's not possible to use the OS separator to create folder hierarchies like 'MyParentFolder'", | ||
| File.separator, "'MyFolder'.", "Please use newFolder('MyParentFolder', 'MyFolder') instead")); |
There was a problem hiding this comment.
Also, let's not put a line break in the message. Thanks.
…f temporary folder
|
Validating for |
|
If it accepts it. I think we should. Any other special cases? |
|
One way to see if a path segment is valid is to use it to create a |
|
Working on improving that; |
|
Fixed with #974 |
|
Hey, guys. What happened? |
|
Please read @kcooney's comment. |
|
I've read it. I just don't understand what happened... I am kind of new. Thanks! |
Adding error message explaining that you can't create a tempFolder using "Parent/Folder" as one string.