Switch to EventSource #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- One request per user, with automatic reconnects! Much better than getting request logs be flodded by calls to /metrics - Doesn't overlap with the prometheus endpoint at /metrics anymore IE doesn't support EventSource, so we need to figure out how to add a shim
Plugins can provide resource usage metrics that are sent to the client via the eventsource
I like this a little better, since we can add more resources other than memory later. Also pass the notebookapp to plugins, rather than specific config. They can thus use their own configurables
Closed
|
Would be nice to resurrect this. |
davidbrochart
pushed a commit
to davidbrochart/jupyter-resource-usage
that referenced
this pull request
Dec 14, 2022
…nt-pooling Pool only the active kernel and if the sidebar is visible
|
And the universe keeps spinning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using EventSource
better than getting request logs be flodded by calls to
/metrics
/metrics anymore
TODO:
Add plugin mechanism
to the client on the same EventSource.