Skip to content

tests: install test-functional requirements for Jupytext downstream tests #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MaicoTimmerman
Copy link
Contributor

Recent released commit in Jupytext (mwouts/jupytext@cb96a90#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R59), introduced black as requirement for their functional tests.

Even though --ignore=tests/functional/others is set, pytest will import the whole test suite during the test gather phase, thus requiring black.

In this MR, we update the package_spec to grab all dependencies required for the test and test-functional.

Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zsailer Zsailer merged commit 75f5152 into jupyter-server:main Apr 14, 2025
37 of 38 checks passed
@MaicoTimmerman MaicoTimmerman deleted the fix-jupytext-downstream-tests branch April 15, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants