Skip to content

Compatibility with Tornado 5.0 #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rolweber opened this issue Mar 14, 2018 · 2 comments
Closed

Compatibility with Tornado 5.0 #281

rolweber opened this issue Mar 14, 2018 · 2 comments

Comments

@rolweber
Copy link
Contributor

rolweber commented Mar 14, 2018

Our unit tests are failing with Tornado 5.0, as exposed by PR #280.

http://www.tornadoweb.org/en/stable/releases/v5.0.0.html

@rolweber
Copy link
Contributor Author

A cheap trick would be to require Tornado<5.0a. But we should rather ensure that the unit tests and KG itself work with Tornado 5.0.

@kevin-bates
Copy link
Member

We see the same issue in Enterprise Gateway (of course) and have documented it in JEG 278. In the meantime, we updated the build to limit Tornado versions to < 5.0 so as to reduce the noise on regular PR traffic.

Another primary change is the removal of the ioloop parameter from various methods - which is why updates to jupyter_client and notebook (et al) are referenced in the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants