Add reason argument to set_status() so that custom messages flow #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm - looks like this breaks the tests. Need to determine what's going on here. |
kevin-bates
added a commit
to kevin-bates/enterprise_gateway
that referenced
this pull request
Apr 23, 2018
This PR also requires [Kernel Gateway PR 284](jupyter-server/kernel_gateway#284) In absence of that PR, the default message corresponding to the status code will be returned to the caller. So this PR is essentially preparation to have custom error messages returned. Fixes jupyter-server#296
kevin-bates
added a commit
to kevin-bates/enterprise_gateway
that referenced
this pull request
Apr 23, 2018
This PR also requires [Kernel Gateway PR 284](jupyter-server/kernel_gateway#284) In absence of that PR, the default message corresponding to the status code will be returned to the caller. So this PR is essentially preparation to have custom error messages returned. Fixes jupyter-server#296
Without adding a named argument of `reason` to tornado's `set_status()` method, messages associated with a thrown HTTPError will not be returned to the caller. Instead, the reason corresponding to the built-in status code is returned. In addition, because the reason argument is used, enforcement of a built in status code is skipped, thereby allowing for the optional use of non-builtin status codes. Updated the TestableJSONErrorsHandler class to have a compatible signature to Torado's `set_status()` method (to include the `reason` parameter). Fixes jupyter-server#283
kevin-bates
force-pushed
the
enable-custom-error-messages
branch
from
de82378 to
81c8a12
Compare
|
I've amended the PR such that |
|
PR seems reasonable to me. (Pun intended.) Thanks @kevin-bates! |
lresende
pushed a commit
to jupyter-server/enterprise_gateway
that referenced
this pull request
May 2, 2018
This PR also requires [Kernel Gateway PR 284](jupyter-server/kernel_gateway#284) In absence of that PR, the default message corresponding to the status code will be returned to the caller. This PR is essentially preparation to have custom error messages returned. Fixes #296 Closes #310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without adding a named argument of
reasonto tornado'sset_status()method, messages associated with a thrown HTTPError will not be returned
to the caller. Instead, the reason corresponding to the built-in status
code is returned. In addition, because the reason argument is used,
enforcement of a built in status code is skipped, thereby allowing for
the optional use of non-builtin status codes.
Fixes #283