Skip to content

Commit c5ef4b9

Browse files
committed
Merge pull request #557 from afshin/typeset
Simplify typeset function.
2 parents ea467d3 + 39c4090 commit c5ef4b9

File tree

2 files changed

+8
-28
lines changed

2 files changed

+8
-28
lines changed

jupyter-js-widgets/src/utils.js

+7-27
Original file line numberDiff line numberDiff line change
@@ -143,42 +143,22 @@ function reject(message, log) {
143143
}
144144

145145
/**
146-
* Apply MathJax rendering to an element, and optionally set its text
146+
* Apply MathJax rendering to an element, and optionally set its text.
147147
*
148148
* If MathJax is not available, make no changes.
149149
*
150-
* Returns the output any number of typeset elements as an array or undefined if
151-
* MathJax was not available.
152-
*
153150
* Parameters
154151
* ----------
155-
* element: Node, NodeList, or jQuery selection
156-
* text: option string
152+
* element: Node
153+
* text: optional string
157154
*/
158155
function typeset(element, text) {
159-
if (arguments.length > 1) {
160-
if (element.length) {
161-
for (var i = 0; i < element.length; ++i) {
162-
var el = element[i];
163-
el.textContent = text;
164-
}
165-
} else {
166-
element.textContent = text;
167-
}
156+
if (text !== void 0) {
157+
element.textContent = text;
168158
}
169-
if (!window.MathJax) {
170-
return;
171-
}
172-
var output = [];
173-
if (element.length) {
174-
for (var i = 0; i < element.length; ++i) {
175-
var el = element[i];
176-
output.push(MathJax.Hub.Queue(['Typeset', MathJax.Hub, el]));
177-
}
178-
} else {
179-
output.push(MathJax.Hub.Queue(['Typeset', MathJax.Hub, element]));
159+
if (window.MathJax) {
160+
MathJax.Hub.Queue(['Typeset', MathJax.Hub, element]);
180161
}
181-
return output;
182162
}
183163

184164
/**

jupyter-js-widgets/src/widget.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -759,7 +759,7 @@ var DOMWidgetViewMixin = {
759759
},
760760

761761
typeset: function(element, text){
762-
utils.typeset.apply(null, arguments);
762+
utils.typeset(element, text);
763763
}
764764
};
765765

0 commit comments

Comments
 (0)