Simplify typeset function. #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this function should be update to explain the new call signature. |
| } else { | ||
| element.textContent = text; | ||
| } | ||
| if (text) { |
There was a problem hiding this comment.
Let's unconditionally set the text. Suppose I have a label widget which sets the content based on a text string coming from python. If the user for whatever reason sets the content to '', this function will now keep the original text since '' is false in Javascript.
There was a problem hiding this comment.
Or even better, we can keep it optional, but explicitly check to see if text is undefined.
|
Thanks! |
|
👍
|
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
typesetfunction can be dramatically simplified because we do not pass element collections to it. It was implemented to support collections because it was ported over from ajQueryimplementation andjQueryobjects are collections by default. But it is not necessary in the current codebase.cf. #544
cc: @jasongrout @SylvainCorlay