-
Notifications
You must be signed in to change notification settings - Fork 950
Add settings for Binder #2659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings for Binder #2659
Conversation
|
||
set -e | ||
|
||
./dev-install.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the Binder is user facing, how about using a released version of ipywidgets
instead?
This would mean adding ipywidgets=7.5
to environment.yml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can create a Binder image for any given commit in the repo. I would expect each of those to have the appropriate version of ipywidgets
and jupyter-widgets/jupyterlab-manager
installed.
If all goes well (and I'm currently not sure that it will), I would like to do the same thing for the docs on RTD, which would mean that the latest
docs are actually using the master
version of the software.
And then, we could create Binder links on the RTD pages which link from a specific version of the docs to the exact same version running on Binder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, for this use case then it makes sense to do a dev install.
For JupyterLab, specifying |
Thanks @jtpio! Now the above-mentioned error doesn't appear anymore, but the Binder build is hanging at some point. This is the link I tried: I've kept the page open for more than an hour now and it's still not finished. Any ideas what the problem could be? |
UPDATE: I've just started the Binder build again (and again), and after a few minutes it now gives me the original error. |
But it looks like @jtpio changed his mind, see #2659 (comment).
Sure. The question is only: which version of the JupyterLab manager? I'm arguing that it should be the version corresponding to whatever commit is used in Binder. What if you want to try out a new feature (probably from some feature branch, probably even from a fork) in Binder? |
Sorry @mgeier for the confusion. My comment was directed to the particular use case of being able to pin a Binder to a specific commit. |
By the way, is this PR still needed or replaced by #2701? |
Sadly, this doesn't work yet.
There is an error when running
./dev-install.sh
on Binder:Apparently, the JupyterLab and
jupyter-widgets/jupyterlab-manager
versions have to match (see https://github.com/jupyter-widgets/ipywidgets/blob/master/packages/jupyterlab-manager/README.md), but I don't know how to handle this in a development installation ...Any ideas?
See #2301.