Skip to content

Fix slider format #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Conversation

davidbrochart
Copy link
Member

Fixes #3102

@davidbrochart
Copy link
Member Author

There is another bug when using continuous_update=True, the front-end sometimes receives value updates with options={} although we should have an options.updated_view equal to this, and so there is an infinite value update even though this view originated the change.

@davidbrochart
Copy link
Member Author

This was caused by to returning a string, and so did get, see the documentation:
"Note that if the .to() method returns a Number, noUiSlider's .get() will also return Numbers."
Should be OK now.

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried locally, worked properly on my side

@SylvainCorlay SylvainCorlay merged commit d23eddc into jupyter-widgets:master Feb 11, 2021
@davidbrochart davidbrochart deleted the fix_slider branch February 11, 2021 13:40
@jasongrout jasongrout added this to the 8.0 milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive fails for non-zero decimal default argument
4 participants