Update linting

.github/workflows/lint.yml

@@ -26,4 +26,4 @@ jobs:
       run: |
         yarn install --frozen-lockfile
         yarn run integrity
-        yarn run eslint:check
+        yarn run lint:check

examples/web1/index.js

@@ -3,7 +3,7 @@ var WidgetManager = require('./manager').WidgetManager;
 
 require('@jupyter-widgets/controls/css/widgets.css');
 
-document.addEventListener('DOMContentLoaded', function(event) {
+document.addEventListener('DOMContentLoaded', function (event) {
   var manager = new WidgetManager(document.body);
 
   /**
@@ -16,20 +16,20 @@ document.addEventListener('DOMContentLoaded', function(event) {
       .new_model({
         model_module: '@jupyter-widgets/controls',
         model_name: widgetType + 'Model',
-        model_id: 'widget-1'
+        model_id: 'widget-1',
         // Create a view for the model.
       })
-      .then(function(model) {
+      .then(function (model) {
         console.log(widgetType + ' model created');
 
         model.set({
           description: description || '',
-          value: value
+          value: value,
         });
 
         return manager.create_view(model);
       }, console.error.bind(console))
-      .then(function(view) {
+      .then(function (view) {
         console.log(widgetType + ' view created');
         manager.display_view(view);
         return view;
@@ -48,26 +48,26 @@ document.addEventListener('DOMContentLoaded', function(event) {
       model_id: 'widget-2',
       state: {
         source: null,
-        target: null
-      }
+        target: null,
+      },
       // Set the link model state.
     })
-    .then(function(link) {
+    .then(function (link) {
       console.log('link created');
 
-      return Promise.all([textArea, html]).then(function(models) {
+      return Promise.all([textArea, html]).then(function (models) {
         console.log('setting link');
         var textArea = models[0];
         var html = models[1];
         link.set({
           source: [textArea.model, 'value'],
-          target: [html.model, 'value']
+          target: [html.model, 'value'],
         });
         link.save_changes();
         console.log('link set');
       });
     })
-    .then(function() {
+    .then(function () {
       var event = new Event('widgetsRendered');
       document.dispatchEvent(event);
     });

examples/web1/karma.config.js

@@ -1,7 +1,7 @@
 // Karma configuration
 // Generated on Mon Dec 07 2015 08:28:33 GMT-0800 (PST)
 
-module.exports = function(config) {
+module.exports = function (config) {
   var cfg = {
     // base path that will be used to resolve all patterns (eg. files, exclude)
     basePath: '',
@@ -42,8 +42,8 @@ module.exports = function(config) {
     customLaunchers: {
       Chrome_travis_ci: {
         base: 'Chrome',
-        flags: ['--no-sandbox']
-      }
+        flags: ['--no-sandbox'],
+      },
     },
 
     // Continuous Integration mode
@@ -52,7 +52,7 @@ module.exports = function(config) {
 
     // Concurrency level
     // how many browser should be started simultanous
-    concurrency: Infinity
+    concurrency: Infinity,
   };
 
   if (process.env.TRAVIS) {

examples/web1/manager.js

@@ -10,21 +10,21 @@ class WidgetManager extends ManagerBase {
   }
 
   loadClass(className, moduleName, moduleVersion) {
-    return new Promise(function(resolve, reject) {
+    return new Promise(function (resolve, reject) {
       if (moduleName === '@jupyter-widgets/controls') {
         resolve(controls);
       } else if (moduleName === '@jupyter-widgets/base') {
         resolve(base);
       } else {
-        var fallback = function(err) {
+        var fallback = function (err) {
           let failedId = err.requireModules && err.requireModules[0];
           if (failedId) {
             console.log(
               `Falling back to jsDelivr for ${moduleName}@${moduleVersion}`
             );
             window.require(
               [
-                `https://cdn.jsdelivr.net/npm/${moduleName}@${moduleVersion}/dist/index.js`
+                `https://cdn.jsdelivr.net/npm/${moduleName}@${moduleVersion}/dist/index.js`,
               ],
               resolve,
               reject
@@ -35,7 +35,7 @@ class WidgetManager extends ManagerBase {
         };
         window.require([`${moduleName}.js`], resolve, fallback);
       }
-    }).then(function(module) {
+    }).then(function (module) {
       if (module[className]) {
         return module[className];
       } else {
@@ -48,7 +48,7 @@ class WidgetManager extends ManagerBase {
 
   display_view(view) {
     var that = this;
-    return Promise.resolve(view).then(view => {
+    return Promise.resolve(view).then((view) => {
       LuminoWidget.attach(view.luminoWidget, that.el);
       return view;
     });

examples/web1/test/index.js

@@ -11,7 +11,7 @@ const widgetsRendered = new Promise((resolve, reject) => {
   document.addEventListener('widgetsRendered', listener);
 });
 
-describe('index.html', function() {
+describe('index.html', function () {
   this.timeout(10000);
 
   beforeEach(() => {

examples/web1/webpack.config.js

@@ -7,21 +7,21 @@ module.exports = {
   output: {
     filename: 'index.built.js',
     path: path.resolve(__dirname, 'built'),
-    publicPath: 'built/'
+    publicPath: 'built/',
   },
   module: {
     rules: [
       { test: /\.css$/, use: ['style-loader', 'css-loader'] },
       // jquery-ui loads some images
-      { test: /\.(jpg|png|gif)$/, use: 'file-loader' }
-    ]
+      { test: /\.(jpg|png|gif)$/, use: 'file-loader' },
+    ],
   },
   plugins: [
     new webpack.DefinePlugin({
       // Needed for Blueprint. See https://github.com/palantir/blueprint/issues/4393
       'process.env': '{}',
       // Needed for various packages using cwd(), like the path polyfill
-      process: { cwd: () => '/' }
-    })
-  ]
+      process: { cwd: () => '/' },
+    }),
+  ],
 };

examples/web2/index.js

@@ -6,7 +6,7 @@ var WidgetManager = require('./manager').WidgetManager;
 require('@jupyter-widgets/controls/css/widgets.css');
 require('font-awesome/css/font-awesome.css');
 
-document.addEventListener('DOMContentLoaded', function(event) {
+document.addEventListener('DOMContentLoaded', function (event) {
   var code = require('./widget_code.py').default;
   var inputarea = document.getElementsByClassName('inputarea')[0];
   new CodeMirror(inputarea, {
@@ -15,20 +15,20 @@ document.addEventListener('DOMContentLoaded', function(event) {
     tabSize: 4,
     showCursorWhenSelecting: true,
     viewportMargin: Infinity,
-    readOnly: true
+    readOnly: true,
   });
 
   var state = require('./widget_state.json');
   var widgetarea = document.getElementsByClassName('widgetarea')[0];
   var manager = new WidgetManager(widgetarea);
   manager
     .set_state(state)
-    .then(models =>
+    .then((models) =>
       manager.create_view(
         models.find(
-          element => element.model_id == '8621699ecc804983a612f09b7dfe806b'
+          (element) => element.model_id == '8621699ecc804983a612f09b7dfe806b'
         )
       )
     )
-    .then(view => manager.display_view(view));
+    .then((view) => manager.display_view(view));
 });

examples/web2/manager.js

@@ -10,21 +10,21 @@ class WidgetManager extends ManagerBase {
   }
 
   loadClass(className, moduleName, moduleVersion) {
-    return new Promise(function(resolve, reject) {
+    return new Promise(function (resolve, reject) {
       if (moduleName === '@jupyter-widgets/controls') {
         resolve(controls);
       } else if (moduleName === '@jupyter-widgets/base') {
         resolve(base);
       } else {
-        var fallback = function(err) {
+        var fallback = function (err) {
           let failedId = err.requireModules && err.requireModules[0];
           if (failedId) {
             console.log(
               `Falling back to jsDelivr for ${moduleName}@${moduleVersion}`
             );
             window.require(
               [
-                `https://cdn.jsdelivr.net/npm/${moduleName}@${moduleVersion}/dist/index.js`
+                `https://cdn.jsdelivr.net/npm/${moduleName}@${moduleVersion}/dist/index.js`,
               ],
               resolve,
               reject
@@ -35,7 +35,7 @@ class WidgetManager extends ManagerBase {
         };
         window.require([`${moduleName}.js`], resolve, fallback);
       }
-    }).then(function(module) {
+    }).then(function (module) {
       if (module[className]) {
         return module[className];
       } else {
@@ -48,7 +48,7 @@ class WidgetManager extends ManagerBase {
 
   display_view(view) {
     var that = this;
-    return Promise.resolve(view).then(function(view) {
+    return Promise.resolve(view).then(function (view) {
       LuminoWidget.attach(view.luminoWidget, that.el);
       return view;
     });

examples/web2/webpack.config.js

@@ -7,7 +7,7 @@ module.exports = {
   output: {
     filename: 'index.built.js',
     path: path.resolve(__dirname, 'built'),
-    publicPath: 'built/'
+    publicPath: 'built/',
   },
   module: {
     rules: [
@@ -22,29 +22,29 @@ module.exports = {
           loader: 'url-loader',
           options: {
             limit: 10000,
-            mimetype: 'application/font-woff'
-          }
-        }
+            mimetype: 'application/font-woff',
+          },
+        },
       },
       {
         test: /\.woff(\?v=\d+\.\d+\.\d+)?$/,
         use: {
           loader: 'url-loader',
           options: {
             limit: 10000,
-            mimetype: 'application/font-woff'
-          }
-        }
+            mimetype: 'application/font-woff',
+          },
+        },
       },
       {
         test: /\.ttf(\?v=\d+\.\d+\.\d+)?$/,
         use: {
           loader: 'url-loader',
           options: {
             limit: 10000,
-            mimetype: 'application/octet-stream'
-          }
-        }
+            mimetype: 'application/octet-stream',
+          },
+        },
       },
       { test: /\.eot(\?v=\d+\.\d+\.\d+)?$/, use: 'file-loader' },
       {
@@ -53,18 +53,18 @@ module.exports = {
           loader: 'url-loader',
           options: {
             limit: 10000,
-            mimetype: 'image/svg+xml'
-          }
-        }
-      }
-    ]
+            mimetype: 'image/svg+xml',
+          },
+        },
+      },
+    ],
   },
   plugins: [
     new webpack.DefinePlugin({
       // Needed for Blueprint. See https://github.com/palantir/blueprint/issues/4393
       'process.env': '{}',
       // Needed for various packages using cwd(), like the path polyfill
-      process: { cwd: () => '/' }
-    })
-  ]
+      process: { cwd: () => '/' },
+    }),
+  ],
 };

examples/web3/src/index.ts

@@ -7,25 +7,21 @@ import { WidgetManager } from './manager';
 import {
   KernelManager,
   ServerConnection,
-  KernelMessage
+  KernelMessage,
 } from '@jupyterlab/services';
 
 const BASEURL = prompt('Notebook BASEURL', 'http://localhost:8888');
 if (BASEURL === null) {
   alert('A base URL is needed to run the example!');
   throw new Error('A base URL is needed to run the example!');
 }
-const WSURL =
-  'ws:' +
-  BASEURL.split(':')
-    .slice(1)
-    .join(':');
+const WSURL = 'ws:' + BASEURL.split(':').slice(1).join(':');
 
-document.addEventListener('DOMContentLoaded', async function(event) {
+document.addEventListener('DOMContentLoaded', async function (event) {
   // Connect to the notebook webserver.
   const connectionInfo = ServerConnection.makeSettings({
     baseUrl: BASEURL!,
-    wsUrl: WSURL
+    wsUrl: WSURL,
   });
   const kernelManager = new KernelManager({ serverSettings: connectionInfo });
   const kernel = await kernelManager.startNew();
@@ -41,7 +37,7 @@ document.addEventListener('DOMContentLoaded', async function(event) {
     tabSize: 4,
     showCursorWhenSelecting: true,
     viewportMargin: Infinity,
-    readOnly: true
+    readOnly: true,
   });
 
   // Create the widget area and widget manager

examples/web3/src/manager.ts

@@ -38,7 +38,7 @@ export class WidgetManager extends HTMLManager {
   _get_comm_info(): Promise<any> {
     return this.kernel
       .requestCommInfo({ target_name: this.comm_target_name })
-      .then(reply => (reply.content as any).comms);
+      .then((reply) => (reply.content as any).comms);
   }
 
   kernel: Kernel.IKernelConnection;