(Partially) remove jQuery and Bootstrap #427
Conversation
|
👍 thanks for cleaning up the PR ! |
| model.get('_view_name'), | ||
| model.get('_view_module'), | ||
| ManagerBase._view_types | ||
| ).then(function(ViewType) { |
There was a problem hiding this comment.
Ah, more legible, thanks!
| this.label = document.createElement('div'); | ||
| this.label.classList.add('widget-label'); | ||
| this.label.style.display = 'none'; | ||
| this.el.appendChild(this.label); |
There was a problem hiding this comment.
Writing HTML in JS is so awkward (same with the jquery version). This is one of those moments I wish we were using JSX or webpack to pull in the HTML. Maybe in a separate PR we should look into webpacking HTML...
There was a problem hiding this comment.
It's definitely more verbose. The way we mostly deal with it in phosphor is by having a small number of static methods, like createNode, etc. and just having those be pure DOM construction. It ends up being mostly okay at that point. It's not as small as JSX, but it's totally readable and predictable.
| this.droplist.style.maxHeight = availableHeightAbove + 'px'; | ||
| return; | ||
| } | ||
| } |
| var radios = _.pluck( | ||
| this.container.querySelectorAll('input[type="radio"]'), | ||
| 'value' | ||
| ); |
(Partially) remove jQuery and Bootstrap
|
Sweet, thanks! |
|
The heroic work came from @afshin, thanks dude! |
github-actions
bot
added
the
resolved-locked
FYI, @jdfreder @SylvainCorlay @jasongrout @dwillmer ... this is to (soon) supersede #400