Skip to content

Issue 544 bugfixes #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 4, 2016
Merged

Issue 544 bugfixes #555

merged 5 commits into from
May 4, 2016

Conversation

afshin
Copy link
Contributor

@afshin afshin commented May 3, 2016

These are bugfixes for #544

  • Color picker widget respects widget width
  • Dropdown widget respects widget width
  • Progress bar widget renders 'vertical' mode correctly
  • Fix Dropdown widget keydown handler inside notebook

cc: @jasongrout @SylvainCorlay

@afshin
Copy link
Contributor Author

afshin commented May 3, 2016

screen shot 2016-05-03 at 7 24 19 pm

@afshin
Copy link
Contributor Author

afshin commented May 3, 2016

FYI, I added the .fa class back in for button icons.

screen shot 2016-05-03 at 9 03 21 pm

@jasongrout
Copy link
Member

Darian, those changes look good; thanks. One more thing about the dropdown - if the size of the dropdown has changed, the actual dropdown list no longer matches the width of the control (see the image below - the grey box is a different width than the control). Can we get the list to match the width of the control?

screen shot 2016-05-03 at 5 05 31 pm

@afshin
Copy link
Contributor Author

afshin commented May 4, 2016

@jasongrout Good call, the drop list width needs to be calculated at run-time in JS (it used to just be a static 300px).

@jasongrout
Copy link
Member

Nice, thanks! I also investigated a bit more deeply what the <select> behavior is on different platforms over in #562. No conclusions there, but there is precedence for having the dropdown list box width be more than the dropdown control size.

@jasongrout jasongrout merged commit 3ca3d66 into jupyter-widgets:master May 4, 2016
@jasongrout jasongrout added this to the Previous Releases milestone Nov 17, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants