Added bootstrap-tags 1.1

[jdfreder]

No description provided.

[jdfreder]

ipython/ipython#6638

[minrk]

exclude this file via .gitignore

[jdfreder]

@minrk comments addressed and rebased :)

[jdfreder]

Unrebased till @Carreau CM4 PR gets merged into ipython\ipython master.

[jhamrick]

• After you click the filter button, it expands; if you click it again, it collapses, and then can't be expaned again.
• If you start typing in the cell tags area and then click out of the area (or press tab), the tag doesn't get rendered. My expectation is that anything typed into the tags area should become a tag if focus leaves the tags area?

• Is the idea with filtering to be just visual, or should it affect the cells that are run, too? Currently, if you filter out some cells and click "run all", all cells are still run (even hidden ones). Is that intentional?
• If the cursor is in the cell tags area and you press up/down, it does not cause the next/previous cell to be selected (which is what I would have expected). It seems the only way to get out of the tags area via the keyboard is to press "tab", which will move you into the text of the cell if it's a code cell, or to the tags area of the next cell. So if you wanted to go to a previous cell, you would have to do n tabs, escape, then n ups = 2n + 1 key presses, or use the mouse.

[jdfreder]

@jhamrick see my response in ipython/ipython#6638

[ellisonbg]

So cool, some feedback:

• Rendered markdown and heading cells lack the padding inside the selected border. Bug in master also, but I don't want to forget.
• Looks like the celltoolbar background color is different for text and code cells?
• Cells with no tags are no affected by the filter. How should they be treated?
• We should at least register an ESC handler for the tag text area so users can get back to command mode. But that should automatically happen if you are using the keyboard_manager stuff?
• Expression like tag1 and (not tag2) are not working, but tag1 and not tag2 does.
• We should probably save the current filter in notebook metadata and reapply upon a page load.
• Let's remove the glowing blue border from the filter text area when selected.

[jdfreder]

@ellisonbg I will respond in the main PR- ipython/ipython#6638

[jdfreder]

rebased

[minrk]

can you add this just below "bootstrap" to preserve alphabetical order?

[minrk]

looks like it still needs a rebase. Can you put bootstrap-tags above bootstrap-tour? If you do that, I'll go ahead and merge when it's green.

[jdfreder]

@minrk alphabetized and rebased!