add BeakerX tables to widget demos #239
Conversation
|
screenshot: |
|
This PR now fixes the ipyleaflet and pythreejs demos as well as adding the beakerx demo. |
|
cc @SylvainCorlay for bqplot review. |
|
The bqplot example looks fine from a quick glance, but I haven't run it. |
widgets.html
Outdated
| window.requirejs.onError = function(e) { | ||
| console.log(e); | ||
| // hack! Remove the anonymous require call from https://unpkg.com/@jupyter-widgets/[email protected]/dist/embed-amd.js | ||
| // window.require(['@jupyter-widgets/html-manager/dist/libembed-amd'], ... |
There was a problem hiding this comment.
These lines are not needed, right? Do we need to override the error function at all?
There was a problem hiding this comment.
As described in comment we need to resolve the issue with anonymous require call from https://unpkg.com/@jupyter-widgets/[email protected]/dist/embed-amd.js.
Otherwise if you remove this onerror overridden method the requirejs will throw an error:
Error: Mismatched anonymous define() module: [object Object]
http://requirejs.org/docs/errors.html#mismatch
at makeError (require.min.js:1)
at v (require.min.js:1)
at Object.o [as require] (require.min.js:1)
at requirejs (require.min.js:1)
at embed-amd.js:274986
at Promise (<anonymous>)
at requirePromise (embed-amd.js:274980)
at Object.renderWidgets (embed-amd.js:275006)
at embed-amd.js:281516
and stop working. So the examples won't work as their widgets won't be loaded by requirejs.
There was a problem hiding this comment.
@jasongrout
After debugging the issue of Mismatched anonymous define() module it turned out that it's caused by the anonymous module inside the https://buttons.github.io/buttons.js. After adding the requirejs to http://jupyter.org/widgets the buttons.js script runs the
if typeof define is "function" and define.amd
define [], { render: render }
which causes the error to be thrown. It has nothing to do with the ipywidgets v7.
The github-buttons issue: buttons/github-buttons#31
There was a problem hiding this comment.
Huh. This is part of the reason why we created an html manager that did not use require - because introducing require on a page changes how the js on the page works.
There was a problem hiding this comment.
But still, the example widgets are using the amd modules and depend on RequireJS.
So using the non amd version of ipywidgets will not resolve the issue here.
There was a problem hiding this comment.
afaik the simplest fix would be to not include buttons.js.
it's used to create the github and twitter buttons in the footer.
these buttons could be replaced with simple html.
There was a problem hiding this comment.
I would be 👍 on not including this js at all. cc @ellisonbg
There was a problem hiding this comment.
I've got an answer from the lib author. His solution is to load the lib via the RequireJS. But this would force us to include the RequireJS on other pages as well. I'll provide the non js solution for the Follow button though.
|
I approve the PR, lacking context on the question on the overriding of |
|
hack and buttons.js removed. |
|
I am fine with merging as is. Waiting a bit to give @jasongrout a chance to comment. |
|
@scottdraves btw, it seems that this needs a rebase on master. |
|
rebased |
|
thanks! |
|
Merged! ✨ 🎉 |
atn @jasongrout
note that the 1st pre-existing example (ipyleaflet) is broken: https://github.com/ellisonbg/ipyleaflet/issues/76
i think we know how to fix it, will look further into it next.