Additional run-time configurations for Kernel Gateway #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiti-saxena
force-pushed
the
master
branch
2 times, most recently
from
c4c91dd to
98dd21b
Compare
rolweber
reviewed
Nov 2, 2017
kernel_gateway/gatewayapp.py
Outdated
| The kernel spec manager class to use. Should be a subclass | ||
| of `jupyter_client.kernelspec.KernelSpecManager`. | ||
|
|
||
| The Api of KernelSpecManager is provisional and might change |
There was a problem hiding this comment.
We shouldn't have API warnings from Jupyter Client in the kernel gateway code, I think.
There was a problem hiding this comment.
I wasn't sure what the format for help would be so I copied it from Jupyter Notebook
|
@rolweber I've updated the PR with the suggested changes. Please review it. |
|
The config options look reasonable to me for advanced users. Anyone looking to add a custom kernel manager will need to be careful to support all the mode and option behaviors of the default managers. |
kevin-bates
added a commit
to kevin-bates/enterprise_gateway
that referenced
this pull request
Nov 27, 2017
Applied the recent [JKG PR 266](jupyter-server/kernel_gateway#266) that allows for overrides to the kernelspec and kernel manager classes. Since Enterprise Gateway requires the remote kernel manager classes already, they have been applied as the default values. Users of this feature relative to JKG should still be able to retain their current functionality. However, because those classes won't derive from EG's remote kernel manager classes, they will not be able to leverage the remoting features of EG until those classes also derive from EG's remote kernel manager classes.
lresende
pushed a commit
to jupyter-server/enterprise_gateway
that referenced
this pull request
Dec 1, 2017
Applied the recent PR jupyter-server/kernel_gateway#266 that allows for overrides to the kernelspec and kernel manager classes. Since Enterprise Gateway requires the remote kernel manager classes already, they have been applied as the default values. Users of this feature relative to JKG should still be able to retain their current functionality. However, because those classes won't derive from EG's remote kernel manager classes, they will not be able to leverage the remoting features of EG until those classes also derive from EG's remote kernel manager classes. Closes #233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #265