Skip to content

Fix for "find searches only part of the file" bug #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 12, 2023
Merged

Fix for "find searches only part of the file" bug #6905

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3bf461b
Enabled the Accel F shortcut by default for documentsearch.
ericsnekbytes Jun 7, 2023
f0232a5
Update Playwright Snapshots
github-actions[bot] Jun 8, 2023
71bf2de
Update Playwright Snapshots
github-actions[bot] Jun 8, 2023
20ce5a3
Added tentative find-plugin docs, WIP.
ericsnekbytes Jun 8, 2023
3fff0bc
Merge branch 'find_fixes' of github.com:ericsnekbytes/notebook into f…
ericsnekbytes Jun 8, 2023
4fcc9e1
Removed file with shortcut override.
ericsnekbytes Jun 8, 2023
2383bfc
Cleanup/removal of todo.
ericsnekbytes Jun 9, 2023
1ed8cfa
Update docs/source/notebook.md
jtpio Jun 12, 2023
1aeca1d
Merge branch 'main' into find_fixes
jtpio Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/documentsearch-extension/schema/notebookShellWidgetListener.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"command": "documentsearch:start",
"keys": ["Accel F"],
"selector": ".jp-mod-searchable",
"disabled": true
"disabled": false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these settings only include the keyboard shortcut override, maybe we could actually remove the whole file?

}
],
"properties": {},
Expand Down
Binary file modified ui-tests/test/menus.spec.ts-snapshots/opened-menu-edit-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/test/menus.spec.ts-snapshots/opened-menu-edit-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.