Override xstartup with environment variable JUPYTER_REMOTE_DESKTOP_PROXY_XSTARTUP
#134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines the variable `JUPYTER_REMOTE_DESKTOP_PROXY_XSTARTUP` to launch a custom xstartup script
|
I will automatically update this comment whenever this PR is modified |
consideRatio
approved these changes
Nov 5, 2024
|
I've been prototyping a configurable entrypoint in jupyterhub/jupyter-server-proxy@58e5667 (jupyterhub/jupyter-server-proxy#509) I'm undecided on what's better though, an env-var or the configurable. |
consideRatio
changed the title
JUPYTER_REMOTE_DESKTOP_PROXY_XSTARTUP
|
Let's go with this for now pending jupyterhub/jupyter-server-proxy#509 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines the variable
JUPYTER_REMOTE_DESKTOP_PROXY_XSTARTUPto launch a custom xstartup script.The main benefit of this is launching a different desktop e.g. https://github.com/manics/jupyter-desktop-mate/blob/main/start-mate.sh on a system where a user's home directory may be mounted, meaning
~/.vnc/xstartupdoesn't exist.Ideally this would be done with a traitlets configuration so it could be specified in one of the standard configuration paths, but the VNC server and desktop are launched using a custom jupyter-server-proxy entrypoint
jupyter-remote-desktop-proxy/setup.py
Lines 62 to 64 in 4f68d13
so as far as I know it's not possible to pass a traitlets configuration object to it.