Skip to content

Expand use of JupyterLab components #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 3, 2022
Merged

Expand use of JupyterLab components #60

merged 12 commits into from
Apr 3, 2022

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Apr 3, 2022 •
edited
Loading

References

Changes

  • use MainAreaWidget
    • hoist that widget to manager
    • name and hoist toolbar items from react to widgets
    • host sidebar/main area toggle to separate widget
  • use ITranslator
    • in main area widget
    • in manager (e.g. error messages)
    • in react components
  • only re-add widget to shell if area has changed

@bollwyvl bollwyvl changed the title Expand use of lab components Expand use of JupyterLab components Apr 3, 2022
@bollwyvl bollwyvl merged commit a0c7bd1 into jupyterlab-contrib:develop Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bollwyvl