Clear input state if applicable before hopping out of normal mode to jupyter command mode #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ryantam626
force-pushed
the
rt.incremental-esc-fix
branch
from
c8051c5 to
a31eee7
Compare
|
@ryantam626 sorry I wasn't able to look at this when it was opened. This looks quite good and important for resolving #73 do you have the time to rebase? if not I'm happy to take over this PR |
…jupyter command mode For example if I press `d` then `<Esc>` in normal mode (i.e. about to delete something but changed my mind), I expect to be still in normal mode instead of jupyter command mode.
ryantam626
force-pushed
the
rt.incremental-esc-fix
branch
from
a31eee7 to
c72e82e
Compare
|
@ianhi done 🙌 - looks like I am not supposed to touch the changelog so I have left it alone. |
|
this looks correct. but just to ensure im testing it properly, how are you invoking this command? Have you modified the keyboard shortcuts to bind esc to |
|
ok turns out i really had to muck around with my keyboard shortcuts to get that to go. not sure why I had such trouble. but certainly seems good to me. thanks! |
ianhi
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example if I press
dthen<Esc>in normal mode (i.e. about to delete something but changed my mind), I expect to be still in normal mode instead of jupyter command mode.