Use plotly.js browser script vs. npm module #32
Conversation
gnestor
force-pushed
the
fix-plotly
branch
2 times, most recently
from
149eef1 to
b2be961
Compare
| loading = true; | ||
| const script = document.createElement('script'); | ||
| script.type = 'text/javascript'; | ||
| script.text = require('raw-loader!../vendor/plotly-1.28.3.min.js'); |
There was a problem hiding this comment.
@blink1073 Ideally, we could just set script.src to the relative path of the plotly.js file, but unfortunately that won't work once it's all bundled with webpack. Using raw-loader, we can get the content of the plotly.js file and set script.text, but this seems a little hacky... 🤔
There was a problem hiding this comment.
You don't even need to vendor the file if you use the raw-loader, you can use raw-loader!plotly/dist/plotly.min.js. I think that this approach is fine.
There was a problem hiding this comment.
Do you mean raw-load it from a CDN?
There was a problem hiding this comment.
No, as a third party import that webpack will resolve.
There was a problem hiding this comment.
But we don't load the script until it is actually needed.
There was a problem hiding this comment.
Can you show me what you mean?
There was a problem hiding this comment.
script.text = require('!raw-loader!plotly/dist/plotly.min.js'), where plotly/dist/plotly.min.js is the location of the file in node_modules.
There was a problem hiding this comment.
Oh ok, I like that better 👍
Closes #21
Resolves an issue with bundling plotly.js using webpack: https://github.com/plotly/plotly.js#building-plotlyjs-with-webpack