Add code signing for macOS and Windows

[mbektas]

add code signing for macOS and Windows

[mbektas]

@ellisonbg could you share the code signing information with me (as you had mentioned #191 (comment))? we are now ready to add code signing.

[ellisonbg]

Hi Mehmet, I will work on this - what email should I use in communicating privately with you?

…

On Wed, Sep 15, 2021 at 1:47 PM Mehmet Bektas ***@***.***> wrote: @ellisonbg <https://github.com/ellisonbg> could you share the code signing information with me (as you had mentioned #191 (comment) <#191 (comment)>)? we are now ready to add code signing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#202 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAGXUF4CA4GTTC46T7KPBTUCEA43ANCNFSM5EAYVLIA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Brian E. Granger Principal Technical Program Manager, AWS AI Platform ***@***.***) On Leave - Professor of Physics and Data Science, Cal Poly @ellisonbg on GitHub

[simonw]

I'd love to know how you end up solving the Windows code signing aspect of this. In case they are useful, here are my notes on how I got macOS code signing to work: https://til.simonwillison.net/electron/sign-notarize-electron-macos

[alexander-manley]

@simonw @ellisonbg @mbektas
Official docs:
https://docs.microsoft.com/en-us/windows-hardware/drivers/dashboard/get-a-code-signing-certificate

Proven step-by-step CI/CD signing solution:
https://shipshape.io/blog/signing-electron-apps-with-github-actions/

Step 1: Buy an EV Code Signing Certificate.
Step 2: Install the Certificate via a Github action
Step 3: Build and release a validated app

[krassowski]

I believe that the MacOS part was solved, with the previous discussion taking part in #68, is this correct?

[krassowski]

Problem:

• lack of Windows certificate flags the app as dangerous, see Windows installer - missting sign certificate #660 and Windows Defender shows warning on Setup installer download #261
• the above is one reason why I recommended against adding a download link on jupyter.org some time ago
• whic means users decide the app (and maybe even Jupyter) is not trustworthy, for example Document where on jupyter.org Jupyterlab App is listed for download #275

As per #648 (comment) there appears to be a delay related to coordination with NUMFocus. @mbektas is there a way I could help to push this forward? I understand that three members of Jupyter EC are on NUMFocus Advisory Council (@ellisonbg @jasongrout @fperez), and @SylvainCorlay is on the Board of Directors - could maybe contacting them help to move this along?

[fperez]

FYI @krassowski - we got an email from @mbektas yesterday about this and it's now on our radar. Supporting this kind of thing is the kind of thing that falls under the EC's purview, so we'll get to it as soon as possible.

[krassowski]

Was EC able to push it forward?

[ellisonbg]

Thanks for the ping, no progress yet, blocking on NumFOCUS.

…

On Tue, Aug 15, 2023 at 2:25 PM Michał Krassowski ***@***.***> wrote: Was EC able to push it forward? — Reply to this email directly, view it on GitHub <#202 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAGXUFNRWTUB4HMJELGO6DXVPSLDANCNFSM5EAYVLIA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Brian E. Granger Senior Principal Technologist, AWS AI/ML ***@***.***) On Leave - Professor of Physics and Data Science, Cal Poly @ellisonbg on GitHub

[krassowski]

@mbektas is the certificate from NumFOCUS available now?

[mbektas]

It is purchased now and I will be working with NumFOCUS to integrate the certificate.

[AnotherTankDoor]

This appears to still be an issue.