Skip to content

env install on first run, macOS code sign #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Mar 28, 2022
Merged

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Mar 18, 2022

  • Install Python environment to user data directory
  • Install Python environment on demand, if no (compatible) environment set / found
  • macOS code signing and notarization
  • Use DMG installation for macOS
  • Skip code signing for PRs from forks
  • Create macOS jlab command on first run
  • Improve env installer UI
  • Update documentation

These changes will also pave the way for automatic updates.

Environment installation progress display
Environment installation prgress

Overwrite prompt if user has existing environment installed using bundled installer, but it is not compatible anymore
overwrite prompt

Installation error messages
Install error messages

DMG installer on macOS
new dmg installer

Code signed on macOS
code signed

@mbektas mbektas mentioned this pull request Mar 19, 2022
@mbektas mbektas marked this pull request as draft March 19, 2022 00:58
@mbektas mbektas requested a review from krassowski March 22, 2022 15:30
@mbektas mbektas marked this pull request as ready for review March 24, 2022 17:23
@mbektas mbektas closed this Mar 25, 2022
@mbektas mbektas reopened this Mar 25, 2022
@mbektas mbektas merged commit 2ce9c04 into master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant